memory leak in SqlDataAdapter.Fill method?

5 Apr 2005 3:29 PM

Ben

I have a program that invokes the following block of code every x
seconds. The process private bytes keeps increasing after every call.
I've try to dispose the SQlDataAdapter in the finally block, but did
not work. If I invoke the garbage collector manually GC.Collect in the
finally block, there is no more memory leak. What's wrong with the
following block of code? Is there a real leak or am I missing
something?

I've been working on this for few days, but I cannot figure it out.
Please help!

private DataSet GetJobQ()
{
DataSet    ds   = new DataSet();
SqlConnection    conn = new SqlConnection( "myconnectionstring" );
SqlDataAdapter adpt = new SqlDataAdapter( "EXEC GetJobQ", conn );

try
{
    adpt.Fill( ds );
}
finally
{
    con.Close();
}
return ds;
}

5 Apr 2005 3:54 PM

Alex Passos

What is happening with the data set you are returning? Is it being merged
with another set? If the data set data is incrementally populating some grid
control for example you should expect the data from the database to take up
memory incrementally.

Show quoteHide quote

"Ben" <benoit.lecl***@bell.ca> wrote in message
news:29f894de.0504050729.18bbee01@posting.google.com...
>I have a program that invokes the following block of code every x
> seconds. The process private bytes keeps increasing after every call.
> I've try to dispose the SQlDataAdapter in the finally block, but did
> not work. If I invoke the garbage collector manually GC.Collect in the
> finally block, there is no more memory leak. What's wrong with the
> following block of code? Is there a real leak or am I missing
> something?
>
> I've been working on this for few days, but I cannot figure it out.
> Please help!
>
> private DataSet GetJobQ()
> {
> DataSet ds   = new DataSet();
> SqlConnection conn = new SqlConnection( "myconnectionstring" );
> SqlDataAdapter adpt = new SqlDataAdapter( "EXEC GetJobQ", conn );
>
> try
> {
>    adpt.Fill( ds );
> }
> finally
> {
>    con.Close();
> }
> return ds;
> }

5 Apr 2005 4:05 PM

Matthew Holton

Ben,

I would place clean up code in the finally block or inside of your try.

private DataSet GetJobQ()
{
try
{

#region Prepare the objects
DataSet    ds   = new DataSet();
SqlConnection    conn = new SqlConnection( "myconnectionstring" );
SqlDataAdapter adpt = new SqlDataAdapter( "EXEC GetJobQ", conn );
#endregion

#region All 'opens' should use 'close' Cleanup
con.Close();
#endregion

#region Inner Try
try
{
adpt.Fill( ds );
}
catch (SQlException ex)
{
//Determine if you can handle this exception here
//otherwise rethrow the exception
}
#endregion

}
catch (exception e)
{
//Determine if you can handle this exception here
//otherwise rethrow the exception
}
finally
{

#region Release Objects
conn = null;
adpt = null;
#endregion

}

return ds;

}

private DataSet GetJobQ()
{
   DataSet    ds   = new DataSet();
   SqlConnection    conn = new SqlConnection( "myconnectionstring" );
   SqlDataAdapter adpt = new SqlDataAdapter( "EXEC GetJobQ", conn );

   try
   {
     adpt.Fill( ds );
   }
   finally
   {
     con.Close();
   }
   return ds;
}

Show quoteHide quote

"Ben" wrote:

> I have a program that invokes the following block of code every x
> seconds. The process private bytes keeps increasing after every call.
> I've try to dispose the SQlDataAdapter in the finally block, but did
> not work. If I invoke the garbage collector manually GC.Collect in the
> finally block, there is no more memory leak. What's wrong with the
> following block of code? Is there a real leak or am I missing
> something?
>
> I've been working on this for few days, but I cannot figure it out.
> Please help!
>
> private DataSet GetJobQ()
> {
>   DataSet    ds   = new DataSet();
>   SqlConnection    conn = new SqlConnection( "myconnectionstring" );
>   SqlDataAdapter adpt = new SqlDataAdapter( "EXEC GetJobQ", conn );
>
>   try
>   {
>     adpt.Fill( ds );
>   }
>   finally
>   {
>     con.Close();
>   }
>   return ds;
> }
>

5 Apr 2005 4:16 PM

Miha Markic [MVP C#]

Hi Ben,

As GC runs on non-deterministic times it is normal that memory increases
until GC runs.
Your code is fine and you even don't need explicit close as it is handled by
Fill method in this case.

--
Miha Markic [MVP C#] - RightHand .NET consulting & development
www.rthand.com
SLODUG - Slovene Developer Users Group www.codezone-si.info

Show quoteHide quote

"Ben" <benoit.lecl***@bell.ca> wrote in message
news:29f894de.0504050729.18bbee01@posting.google.com...
>I have a program that invokes the following block of code every x
> seconds. The process private bytes keeps increasing after every call.
> I've try to dispose the SQlDataAdapter in the finally block, but did
> not work. If I invoke the garbage collector manually GC.Collect in the
> finally block, there is no more memory leak. What's wrong with the
> following block of code? Is there a real leak or am I missing
> something?
>
> I've been working on this for few days, but I cannot figure it out.
> Please help!
>
> private DataSet GetJobQ()
> {
> DataSet ds   = new DataSet();
> SqlConnection conn = new SqlConnection( "myconnectionstring" );
> SqlDataAdapter adpt = new SqlDataAdapter( "EXEC GetJobQ", conn );
>
> try
> {
>    adpt.Fill( ds );
> }
> finally
> {
>    con.Close();
> }
> return ds;
> }

5 Apr 2005 5:47 PM

Cowboy (Gregory A. Beamer) - MVP

Use Dispose() and be patient, as GC runs on its own (may not see instant
memory release).

---

Gregory A. Beamer
MVP; MCP: +I, SE, SD, DBA

***************************
Think Outside the Box!
***************************

Show quoteHide quote

"Ben" wrote:

> I have a program that invokes the following block of code every x
> seconds. The process private bytes keeps increasing after every call.
> I've try to dispose the SQlDataAdapter in the finally block, but did
> not work. If I invoke the garbage collector manually GC.Collect in the
> finally block, there is no more memory leak. What's wrong with the
> following block of code? Is there a real leak or am I missing
> something?
>
> I've been working on this for few days, but I cannot figure it out.
> Please help!
>
> private DataSet GetJobQ()
> {
>   DataSet    ds   = new DataSet();
>   SqlConnection    conn = new SqlConnection( "myconnectionstring" );
>   SqlDataAdapter adpt = new SqlDataAdapter( "EXEC GetJobQ", conn );
>
>   try
>   {
>     adpt.Fill( ds );
>   }
>   finally
>   {
>     con.Close();
>   }
>   return ds;
> }
>

5 Apr 2005 6:11 PM

Miha Markic [MVP C#]

Right, he should use Dispose (even if does nothing in this case).

--
Miha Markic [MVP C#] - RightHand .NET consulting & development
www.rthand.com
SLODUG - Slovene Developer Users Group www.codezone-si.info

Show quoteHide quote

"Cowboy (Gregory A. Beamer) - MVP" <NoSpamMgbworld@comcast.netNoSpamM> wrote
in message news:89D51060-7F28-4807-B1BB-BA5608EE4AB7@microsoft.com...
> Use Dispose() and be patient, as GC runs on its own (may not see instant
> memory release).
>
>
> ---
>
> Gregory A. Beamer
> MVP; MCP: +I, SE, SD, DBA
>
> ***************************
> Think Outside the Box!
> ***************************
>
> "Ben" wrote:
>
>> I have a program that invokes the following block of code every x
>> seconds. The process private bytes keeps increasing after every call.
>> I've try to dispose the SQlDataAdapter in the finally block, but did
>> not work. If I invoke the garbage collector manually GC.Collect in the
>> finally block, there is no more memory leak. What's wrong with the
>> following block of code? Is there a real leak or am I missing
>> something?
>>
>> I've been working on this for few days, but I cannot figure it out.
>> Please help!
>>
>> private DataSet GetJobQ()
>> {
>>   DataSet ds   = new DataSet();
>>   SqlConnection conn = new SqlConnection( "myconnectionstring" );
>>   SqlDataAdapter adpt = new SqlDataAdapter( "EXEC GetJobQ", conn );
>>
>>   try
>>   {
>>     adpt.Fill( ds );
>>   }
>>   finally
>>   {
>>     con.Close();
>>   }
>>   return ds;
>> }
>>

6 Apr 2005 5:13 PM

benoit.leclerc

Invoking the Dispose() function solve the problem, the memory tend to
stabilize after a certain amount of time (the time the GC does his
work).

Thank's